Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sigv4 authentication #355

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Add sigv4 authentication #355

merged 2 commits into from
Feb 16, 2021

Conversation

vladimirmukhin
Copy link
Contributor

Sigv4 is a prerequisite for connecting to a Prometheus data source that is managed by AWS
https://docs.aws.amazon.com/prometheus/latest/userguide/AMP-onboard-query-standalone-grafana.html

Upgrade to Grafana 7.3.1 is required since sigv4 is introduced there

@openshift-ci-robot
Copy link

Hi @vladimirmukhin. Thanks for your PR.

I'm waiting for a integr8ly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

verified on upgrade, configuration is propagated to grafana, thanks for contributing @vladimirmukhin 👍

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HubertStefanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HVBE
Copy link
Collaborator

HVBE commented Feb 16, 2021

also @pb82 FYI, this PR upgrades the base image to 7.3.1

@openshift-merge-robot openshift-merge-robot merged commit 1c70bdb into grafana:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants