Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide openshift and kubernetes specific examples for persistent vol… #396

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

pb82
Copy link
Collaborator

@pb82 pb82 commented Apr 20, 2021

Description

Provide examples for external data storage that work on Kubernetes and OpenShift.

Type of change

Examples and docs only.

@pb82 pb82 requested a review from HVBE April 20, 2021 09:45
@pb82
Copy link
Collaborator Author

pb82 commented Apr 20, 2021

supersedes #301

@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2021

@pb82: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/unit a3228a0 link /test unit
ci/prow/format a3228a0 link /test format
ci/prow/images a3228a0 link /test images
ci/prow/e2e a3228a0 link /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

Looks good to me, should close #301

@HVBE
Copy link
Collaborator

HVBE commented Apr 20, 2021

/closes #300

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HubertStefanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HVBE HVBE merged commit f12281b into grafana:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Deploying Grafana with dataStorage configured fails to start Grafana
3 participants