Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe using environment variables in data sources #398

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

pb82
Copy link
Collaborator

@pb82 pb82 commented Apr 20, 2021

Description

Add an example and docs to show how to use environment variables in data sources.

Type of change

Docs and example only.

fixes #393

@pb82 pb82 requested a review from HVBE April 20, 2021 10:54
@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2021

@pb82: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e 8c7eb06 link /test e2e
ci/prow/unit 8c7eb06 link /test unit
ci/prow/format 8c7eb06 link /test format
ci/prow/images 8c7eb06 link /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

Nice to have this cleared up 👍

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HubertStefanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pb82 pb82 merged commit 58931cd into grafana:master Apr 20, 2021
@pb82 pb82 deleted the datasource-env-vars branch April 20, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to provide Username/Password etc. attributes with Kubernetes secrets for GrafanaDatasources
3 participants