Watch namespaces based on CR value #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sedroche
force-pushed
the
INTLY-796-watch-namespaces-based-on-cr-selector
branch
from
a3d8589
to
513ad1b
Compare
|
👀 |
david-martin
reviewed
Feb 4, 2019
pkg/controller/grafana/kubeHelper.go
Outdated
| selector := metav1.ListOptions{ | ||
| LabelSelector: "monitoring=enabled", | ||
| LabelSelector: ss, |
There was a problem hiding this comment.
@sedroche for readability, probably better to have something like selector and selectorString instead of s and ss
sedroche
force-pushed
the
INTLY-796-watch-namespaces-based-on-cr-selector
branch
from
513ad1b
to
66882cc
Compare
pb82
approved these changes
Feb 4, 2019
|
@pb82 yep, empty matches everything. null matches nothing => https://github.com/integr8ly/grafana-operator/pull/4/files#diff-39459cd6e907cd9011fff8584e63b8eaR22 |
9 tasks
kd7lxl
referenced
this pull request
in kd7lxl/grafana-operator
Mar 11, 2021
* adding DB password reference to secret * addresing PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://issues.jboss.org/browse/INTLY-796
This PR changes the Grafana operator to monitor namespaces based on a value retrieved from the CR instead of the hardcoded
"monitoring=enabled"label.Grafana CR now takes a labelSelector to filter monitored namespaces.