Update the operator-sdk to the newest version #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removes marked passages - changes build of operator image to the usage of makefile
- updates scorecard - updated label for metrics builder - updates dockerfile
|
Thanks for taking the time to address this! great work, I'll take a look at reviewing and verifying this later on today! 👍 @Voigtus |
HVBE
previously approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Looks good to me, tested it out on minikube, looks like things are being reconciled properly, there isn't a lot of functional logic that was changed between the versions, which is also a good sign.
Thanks for contributing!
@pb82 @NissesSenap let's coordinate on how and when to merge this
|
@Voigtus can you rebase this PR? The reason why we haven't merged it was that we wanted to make sure that we didn't get any issues with the 4.0.1 release. Thanks once again |
|
Yes yes, I can |
# Conflicts: # Makefile
HVBE
previously approved these changes
Oct 26, 2021
pb82
reviewed
Oct 26, 2021
pb82
reviewed
Oct 26, 2021
NissesSenap
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the whole operator from operator-sdk v1.3.0 up to the current version (v1.13.1)
Relevant issues/tickets
#545
Type of change
Update of operator-sdk
Verification steps
Spun up a kind cluster and created the examples from the deploy/examples folder
Disclaimer
I have not touched the openshift-ci folder, since I cant verify the results there.