Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default_home_dashboard_path #602

Merged
merged 4 commits into from
Nov 9, 2021

Conversation

Bobbins228
Copy link
Contributor

@Bobbins228 Bobbins228 commented Nov 9, 2021

Description

Added the option to change the default home dashboard path.

Relevant issues/tickets

Relates to #578

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just one small nitpick.

api/integreatly/v1alpha1/grafana_types.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bobbins228 👍

@HVBE HVBE merged commit aa8dba0 into grafana:master Nov 9, 2021
@Bobbins228 Bobbins228 deleted the add_default_home_dashboard_path branch November 10, 2021 09:04
@ninkaninus
Copy link

@Bobbins228 How do I use this, as the operator provisions the dashboards through the API I am unable to locate them in the container, therefore unable to use this to set a path for the home dashboard as I don't know the path.

@Bobbins228
Copy link
Contributor Author

@ninkaninus I am unsure to be honest. I don't remember how I tested these changes but perhaps someone in the grafana-operator channel on the Kubernetes Slack could help you?

@clementnero
Copy link

@ninkaninus I'm trying to do the same. Did you find a solution ?

@ninkaninus
Copy link

@clementnero We did not manage to do it, as we was waiting on some merges to bitnami's helm chart, we was only on version 3.8.X where the home dashboard provisioning was implemented after version 4.0.0.

Resources I found under the investigation.
bitnami/charts#8059
https://github.com/bitnami/bitnami-docker-grafana/issues/17
#578

I hope to update and test my configuration within 1 month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants