Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add omitempty to dashboard spec json field and generate docs #606

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

HVBE
Copy link
Collaborator

@HVBE HVBE commented Nov 10, 2021

Description

  • adds omitempty to dashboard.spec.json
  • regenerates api-docs
  • fixes misplaced comments in structs, adding descriptions where they aren't supposed to be
  • Set serviceAccountName: grafana-operator-controller-manager

Relevant issues/tickets

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

@HVBE HVBE changed the title fix: add omitempty to dashboard spec json field fix: add omitempty to dashboard spec json field and generate docs Nov 10, 2021
@HVBE
Copy link
Collaborator Author

HVBE commented Nov 10, 2021

Partially addresses comments from #596

Copy link
Collaborator

@NissesSenap NissesSenap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I will also add that you are setting:
serviceAccountName: grafana-operator-controller-manager
in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants