-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add auth.okta to rendered grafana.ini #612
Conversation
Hey @jaredstehler , can you rebase this PR? thanks! :) |
should be set now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for contributing! @jaredstehler 👍
Ahh.. Another rebase please? @jaredstehler |
@HubertStefanski it's a setting that I have done that forces all PR:s to be up to date compared to the latest in the master branch. The reason is so we are 100% sure that the PR won't create any issues with something else, It will also make it possible for us to know that the CI pipelines will be working together with everything in the master branch. @jaredstehler you will have to rebase this PR. Normally us as maintainers can do it but I don't think you gave that access when creating your PR: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork I noticed this when I cloned down your fork and tried to push to it. To make it easier for us to do please give us as maintainers that access or you will have to keep the PR up to date so we can merge it. |
i've rebased; unfortunately it seems GitHub doesn't allow granting such permissions on forks owned by an "org" account, which this one is. In the future i'll fork from my user account. |
Okay good to know. Thanks for the pr @jaredstehler! |
Description
It seems after a refactor of grafana.ini rendering, the section renderer for
auth.okta
was missed.