Making the kustomization deployment story better #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
November 24, 2021 19:52
This should help users easier be able to setup the operator. Instead of having to create some advanced logic the users can point on these folders with there own kustomization files.
This to make it easier when separeting the kustomization logic Specify ./bin/manager in .gitignore
Adding namespace in manifests.
This way we can generate manifests files that can even be applied using kubectl apply -f, that points directly to the correct namespace without any kustomization logic.
I can't make the generated yaml files look good enough any way. So people will have to use kustomization to apply
It won't be as visiable but before making a commit the developer should run make test and nothing should be changed in the repo. This will also look for changes in kustomization mainfest folders
It's a bit painful to do this without getting the old versions. I will try in a seperate PR to make sure there are in line
This shoulden't create issues in test make command
This way a person making a release can use the makefile easily as well.
|
When this is merged my plan is to create a separate PR that will use the manifests files from v4.0.2 tag and use this sciprt to generate kustomization fils for it. |
HVBE
previously approved these changes
Nov 29, 2021
This pipeline now checks for changes in the repo and that is why the pipeline fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Making the kustomization deployment story better by having a easy to use kustomization file that is up to date.
Will also generate specific folders for tagged releases.
From now on using the generated yaml in the e2e scripts to make sure that it tests what the kubernetes users will use to deploy the operator.
Relevant issues/tickets
Partly solves #623
When this get's merged we will need to remove the old deployment files for v3.
Type of change
Checklist
Verification steps
Run the e2e test