-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alerting options for datasources #701
Add alerting options for datasources #701
Conversation
5ee4c9a
to
ebfd46b
Compare
Not sure if I'm missing anything to add these options |
ebfd46b
to
f1aa822
Compare
Made updates that the build failures pointed out. |
api.md changed a lot when I ran |
f1aa822
to
6c63875
Compare
@annymsMthd please run |
6c63875
to
31b7ed1
Compare
Signed-off-by: Joshua Benjamin <joshua.benjamin@iherb.com>
28a35ea
to
1a3e267
Compare
@annymsMthd |
Thanks. Yeah I've done that a few times. Looks like test is failing now because creationTimestamp in the crd manifests.. odd |
No it's because you don't check in all the changes that you have made. I have fixed it now and I will merge it. |
Signed-off-by: Joshua Benjamin joshua.benjamin@iherb.com
Description
Add datasource json options for alertmanager settings
Relevant issues/tickets
n/a
Type of change
Update of datasource.jsondata
Checklist
Verification steps
n/a