Fix Unified Alerting Service Configuration #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb82
reviewed
Jan 17, 2023
| @@ -702,6 +702,10 @@ func (i *GrafanaIni) cfgUnifiedAlerting(config map[string][]string) map[string][ | |||
| items = appendStr(items, "evaluation_timeout", i.cfg.UnifiedAlerting.EvaluationTimeout) | |||
| items = appendInt(items, "max_attempts", i.cfg.UnifiedAlerting.MaxAttempts) | |||
| items = appendStr(items, "min_interval", i.cfg.UnifiedAlerting.MinInterval) | |||
|
|
|||
| items = appendStr(items, "ha_advertise_address", "${POD_IP}:9094") | |||
There was a problem hiding this comment.
Well it would need the pod IP I believe, but if you're referring to the port I believe that can be made configurable if we want to add that field to the Grafana CRD.
|
@celestialorb I'm not familiar with Grafana Alerting, can you please quickly describe why an extra service is required? Thanks! |
|
Extra service is required for ha configuration. Without it grafana will send each alert from every running pod. Also this configuration requires |
pb82
approved these changes
Mar 7, 2023
|
Is there a documentation how to enable this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds another managed Kubernetes service for unified alerting, and adds the appropriate configuration to Grafana to utilize it for such.
Relevant issues/tickets
#855
Type of change
Checklist
Verification steps
While I have verified that the manifests are updated appropriately, I haven't yet verified that the unified alerting functions as intended with these manifests/configuration. I'm throwing this PR up now in order not to forget about it later / gather feedback on it before proceeding further.