Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heights #97

Merged
merged 2 commits into from
Dec 21, 2019
Merged

Fix heights #97

merged 2 commits into from
Dec 21, 2019

Conversation

pb82
Copy link
Collaborator

@pb82 pb82 commented Dec 20, 2019

provides a fix for #93

Adds a compatibility option (spec.compat.fixHeights) for dashboards that have panels with a height property encoded as a number. The Grafana SDK expects a string here. Also, newer Grafana versions don't seem to emit this property in exported dashboards anymore.

This is provided as a switch because it manipulates the json before submitting and we'd usually try to avoid this.

Verification steps:

...
spec:
  compat:
    fixHeights: true
...
  • after a while (max. 30 seconds) the dashboard should get imported successfully

@pb82 pb82 mentioned this pull request Dec 20, 2019
Copy link

@yogeek yogeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that this is working correctly with the compatibility flag

@pb82 pb82 merged commit e451415 into master Dec 21, 2019
@pb82 pb82 deleted the fix-heights branch December 21, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants