Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] basic kustomize installation #984

Merged
merged 7 commits into from
Apr 17, 2023

Conversation

NissesSenap
Copy link
Collaborator

No description provided.

@NissesSenap NissesSenap added the documentation Issues relating to documentation, missing, non-clear etc. label Apr 2, 2023
@NissesSenap NissesSenap enabled auto-merge (squash) April 2, 2023 18:42
@NissesSenap
Copy link
Collaborator Author

Before merging fix #989 (comment)

@HVBE
Copy link
Collaborator

HVBE commented Apr 14, 2023

@NissesSenap can we merge this? seems like the issue you linked has been closed/resolved?

@NissesSenap
Copy link
Collaborator Author

I will take a look at it on Sunday, we need to change from apply to create/replace when it comes to installing the operator.
I will fix it and then we should be good to go.

@NissesSenap
Copy link
Collaborator Author

@HubertStefanski I have now pushed the changes I wanted. Please take a look when you have time.

deploy/kustomize/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I allowed myself to push a commit to fix a typo, Thanks @NissesSenap !

@NissesSenap NissesSenap merged commit 7fd907c into grafana:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues relating to documentation, missing, non-clear etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants