Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dataframe UnMarshalArrow #19

Closed
kylebrandt opened this issue Nov 18, 2019 · 0 comments · Fixed by #23
Closed

Refactor dataframe UnMarshalArrow #19

kylebrandt opened this issue Nov 18, 2019 · 0 comments · Fixed by #23
Assignees
@papagian
Labels
arrow https://godoc.org/github.com/apache/arrow/go/arrow dataframe

Comments

@kylebrandt
Copy link
Contributor

kylebrandt commented Nov 18, 2019 •
edited

Rename when doing this: s/ df.UnMarshalArrow / df.UnmarshalArrow

This is a long sprawling function. Would probably be nice to break up like MarshalArrow with its decoders.

Good way to get some familiarity with the arrow code.
@kylebrandt kylebrandt changed the title s/ df.UnMarshalArrow / df.UnmarshalArrow Refactor dataframe UnMarshalArrow Nov 18, 2019
@kylebrandt kylebrandt added dataframe arrow https://godoc.org/github.com/apache/arrow/go/arrow labels Nov 18, 2019
@kylebrandt kylebrandt mentioned this issue Nov 18, 2019
Closed
5 tasks
@papagian papagian self-assigned this Nov 20, 2019
@papagian papagian mentioned this issue Nov 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@papagian papagian

Labels
arrow https://godoc.org/github.com/apache/arrow/go/arrow dataframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

19 refactor un marshal arrow grafana/grafana-plugin-sdk-go
2 participants
@papagian @kylebrandt