Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duration vector type to dataframe #20

Closed
5 tasks
kylebrandt opened this issue Nov 18, 2019 · 0 comments · Fixed by #155
Closed
5 tasks

Add duration vector type to dataframe #20

kylebrandt opened this issue Nov 18, 2019 · 0 comments · Fixed by #155
Assignees
Labels
arrow https://godoc.org/github.com/apache/arrow/go/arrow dataframe

Comments

@kylebrandt
Copy link
Contributor

kylebrandt commented Nov 18, 2019

Duration type will be useful eventually, good task to get a little familiar with arrow.

All in dataframe package:

  • Make []time.Duration and []*time.Duration Vector types and update newVector()
  • Update NewField to support the type
  • Update golden arrow test file with duration and nullable duration vectors via var update and goldenDF() in arrow_test.go. See dataframe package's README for more info.
  • Make two arrow column builders for these, update buildArrowColumns() type switch to use them, and update fieldToArrow(). See NewDurationBuilder
  • Update the the two type switches in in UnMarhsalArrow to support this field. (May be different if someone has completed Refactor dataframe UnMarshalArrow #19). See NewDurationData
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow https://godoc.org/github.com/apache/arrow/go/arrow dataframe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant