Remove restriction for executable relative file path for nested datasource plugins #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbrowne
requested review from
marefr,
andresmgot and
xnyo
and removed request for
a team
wbrowne
commented
Jun 11, 2024
Comment on lines
+36
to
+37
| if strings.HasPrefix(exe, "../") { | ||
| return exe[3:], nil |
There was a problem hiding this comment.
We could just do this instead here:
Suggested change
| if strings.HasPrefix(exe, "../") { | |
| return exe[3:], nil | |
| return filepath.Base(exe), nil |
ryantxu
approved these changes
Jun 12, 2024
|
Linking this work with this Grafana issue grafana/grafana#83416 (which we can likely close) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For datasource plugins that are nested within an app, today they are required to specify their executable plugin.json field as a file path in parent plugin's folder. (Zabbix, Twinmaker). I don't think we need to be so restrictive, especially since it causes issues with reading these paths on Windows.
Now you can either specify the nested executable field as
../gpx_fooorgpx_foo- both of which will have the same effect. The plan once this PR is merged is that we can remove path information from plugins that are using it - which will fix the issue of building on Windows.Which issue(s) this PR fixes:
Fixes #980.
Special notes for your reviewer:
There's also a test for backwards compatibility.