Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance profiling and allow traces to profiles #1006

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

marefr
Copy link
Member

@marefr marefr commented Jun 12, 2024

What this PR does / why we need it:

Enhances profiling by

  • registering godeltaprof endpoints which is more suitable for continuous profiling of memory, goroutines and mutexes
  • introducing a new environment variable to enable contention profiling (report of all goroutine blocking and mutex contention events rather than a fraction)
  • allowing/enabling use of traces to profiles by labeling spans with profiling attribute (if profiling is enabled).

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Planning to document profiling in https://grafana.com/developers/plugin-tools/create-a-plugin/extend-a-plugin/add-logs-metrics-traces-for-backend-plugins or a new page.

@marefr marefr self-assigned this Jun 12, 2024
@marefr marefr requested a review from a team as a code owner June 12, 2024 10:30
@marefr marefr requested review from wbrowne, andresmgot and xnyo and removed request for a team June 12, 2024 10:30
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits!

backend/setup.go Outdated Show resolved Hide resolved
backend/setup.go Outdated Show resolved Hide resolved
backend/setup.go Outdated Show resolved Hide resolved
Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>
@marefr marefr merged commit 61cba4c into main Jun 12, 2024
4 checks passed
@marefr marefr deleted the enhanced_profiling branch June 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants