Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Split pipelines for PR and main branch #427

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Conversation

marefr
Copy link
Member

@marefr marefr commented Nov 18, 2021

What this PR does / why we need it:
PRs currently triggers two drone builds, one for the PR and one for the push event. Changes to use PR trigger for PRs and push event for main branch.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@marefr marefr requested a review from a team as a code owner November 18, 2021 16:20
@marefr marefr requested review from wbrowne and removed request for a team November 18, 2021 16:20
@marefr marefr added this to In review in Plugins Platform (DEPRECATED) via automation Nov 18, 2021
@marefr marefr self-assigned this Nov 18, 2021
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is it worth running the race detector as a step for pr here too perhaps?

@marefr
Copy link
Member Author

marefr commented Nov 18, 2021

@wbrowne yes as soon as #424 has been fixed

@marefr marefr merged commit e78060a into main Nov 18, 2021
Plugins Platform (DEPRECATED) automation moved this from In review to Done Nov 18, 2021
@marefr marefr deleted the split_ci_pr_main branch November 18, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants