experimental/sdata: Add RefID to writers and readers #627
Conversation
kylebrandt
requested review from
marefr and
andresmgot
and removed request for
a team,
marefr and
andresmgot
| func emptyFrameWithTypeMD(refID string, t data.FrameType, v data.FrameTypeVersion) *data.Frame { | ||
| f := data.NewFrame("").SetMeta(&data.FrameMeta{Type: t, TypeVersion: v}) | ||
| f.RefID = refID | ||
| return f | ||
| } |
There was a problem hiding this comment.
will there be any side effects using empty frame name? Should we fallback to refID as frame name?
There was a problem hiding this comment.
I don't think so. The frame name is never given any meaning in any of these data types currently. So having it zero valued seems appropriate.
There was a problem hiding this comment.
By any chance transformations will break with inconsistent frame names? ( for a same query, valid results have different frame name when no results have empty frame name )
There was a problem hiding this comment.
I'm not aware of anything in transforms that says valid results must have a frame name?
Random sample of one transform seems to work fine?
There was a problem hiding this comment.
yea fine. Just we need to aware of this and document that the frame names can potentially empty or duplicate. so that consumers can use it foolproof.
This makes it so Frames are creating with a RefID which was skipped before.
We do insert this in other parts of the SDK for datasources, but probably better to keep it clear, and I need to specify it in SSE.