Data: Update FieldTypeFor to support nullable fields #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slighly a breaking change since a comment said concrete, but in that case it would return FieldTypeUnknown which would generally panic somewhere else
ryantxu
reviewed
Feb 27, 2023
| default: | ||
| panic(fmt.Sprintf("unsupported vector ptype: %+v", p)) | ||
| } | ||
| } | ||
|
|
||
| // NonNullableType converts the FieldType to the corresponding not-nullable type. | ||
| // Calling this on FieldTypeUnknown will panic. |
There was a problem hiding this comment.
should we panic? or return unknown?
There was a problem hiding this comment.
as long as the panic will always be triggerd in development... panic is OK 🤔
There was a problem hiding this comment.
I think that will just push the panic to later calls, like NewFieldFromType
ryantxu
approved these changes
Feb 28, 2023
yesoreyeram
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slighly a breaking change since a comment said concrete, but in that case it would return FieldTypeUnknown which would generally panic somewhere else