Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gtime_test #637

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Fix gtime_test #637

merged 1 commit into from
Mar 1, 2023

Conversation

andresmgot
Copy link
Contributor

@andresmgot andresmgot commented Mar 1, 2023

What this PR does / why we need it:

1y resolves today to 366 days :) Adapt the test to use the current month and day.

Which issue(s) this PR fixes:

Fixes #636

Special notes for your reviewer:

@andresmgot andresmgot requested a review from a team as a code owner March 1, 2023 11:47
@andresmgot andresmgot requested review from wbrowne and xnyo and removed request for a team March 1, 2023 11:47
Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great!! ✨✨

@andresmgot andresmgot merged commit 3e491ce into main Mar 1, 2023
@andresmgot andresmgot deleted the fixTime branch March 1, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flakey test in gtime_test.go
2 participants