Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing: Support multiple OTel propagators #663

Merged
merged 48 commits into from
Apr 4, 2023
Merged

Tracing: Support multiple OTel propagators #663

merged 48 commits into from
Apr 4, 2023

Conversation

xnyo
Copy link
Member

@xnyo xnyo commented Mar 30, 2023

What this PR does / why we need it:

Allows plugins to propagate context with multiple open telemetry propagators at the same time.

Matches the behaviour added by this PR from core: grafana/grafana#61199

Which issue(s) this PR fixes:

Fixes #657

Special notes for your reviewer:

@xnyo
Tracing: Add tracing interceptors, add middlewares to standalone mode
0bee11e
@xnyo
Tracing: Set otel text map propagator
abd69b8
@xnyo
Tracing: Read tracing environment variables
87cf5b7
@xnyo
Tracing: Always log tracing status
3bb2041
@xnyo
Tracing: Set up Opentelemetry tracer, tracing httpclient middleware
f8d6d0d
@xnyo
Tracing: Initialize tracer before calling NewManager
6097b04 
Ensures the tracer is properly setup before instantiating the ds
@xnyo
Tracing: Set version in default tracer, add TracingOpts
a0d1ae9
@xnyo
Goimports
d0265c6
@xnyo
Merge branch 'main' into giuseppe/tracing
aaa17b7
@xnyo
go mod tidy
e759af5
@xnyo
Goimports
e76606a
@xnyo
Merge branch 'main' into giuseppe/tracing
567550a
@xnyo
Fix merge conflict
06c1723
@xnyo
Initialize tracing in datasource and app Manage
4bb175b
@xnyo
Fix typo
1f30b61
@xnyo
Update TracingMiddleware docstring
f9263fe
@xnyo
Unexport tracingConfig
8b2ef34
@xnyo
Refactor trace provider initialization
796bdf2
@xnyo
Add tests for httpclient tracing middleware
d2438f8
@xnyo
Goimports
d01e3ed
@xnyo
Properly close tracing before returning from Manage
2a7b4a7
@xnyo
Fix imports
11f140e
@xnyo
Apply default grpc middlewares in standalone mode
f7efbc1
@xnyo
Removed opentracing interceptor
52ffe06
@xnyo
Log: Renamed arg err to error
ab4c71e
@xnyo
Remove breaking change in SetupPluginEnvironment
851fbd0
@xnyo
Lower tracing logging to debug level
8c756e2
@xnyo
Add DefaultTracer, add TracingMiddleware to DefaultMiddlewares
d5469a6
@xnyo
Lint
6907127
@xnyo
Lint
50897d4
xnyo and others added 15 commits March 27, 2023 09:42
@xnyo
Merge branch 'main' into giuseppe/tracing
6b92d6a
@xnyo
Renamed plugin env vars for tracing endpoint and propagation
6026864
@xnyo
Moved DefaultTracer to backend package, removed DefaultMiddleware fro…
269416d 
…m middlewares stack
@xnyo
Revert "Moved DefaultTracer to backend package, removed DefaultMiddle…
d4bf0f8 
…ware from middlewares stack"

This reverts commit 269416d.
@xnyo
Changed TracingMiddlewareName to "Tracing"
28e81cd
@xnyo
Merge branch 'main' into giuseppe/tracing
81c0e40
@xnyo
Merge branch 'main' into giuseppe/tracing
20908c0
@xnyo
Refactoring: Moved trace provider to internal package
ec37c5e
@xnyo
Tracing: Support multiple OTel propagators
dad1809
@xnyo
Fix typos (traceprovider -> tracerprovider, NewTextMapPropagator)
ec09517
@xnyo
Merge remote-tracking branch 'origin/giuseppe/tracing' into giuseppe/…
5c2c4de 
…tracing-multiple-propagators
@xnyo
Renamed traceprovider_test.go to tracerprovider_test.go
938ac65
@xnyo
Merge branch 'main' into giuseppe/tracing-multiple-propagators
1fb5d49
@xnyo
Fix package name in tracerprovider_test.go
cd6c50f
@xnyo
Fix traceprovider -> tracerprovider
762b651
@xnyo xnyo added enhancement New feature or request go Pull requests that update Go code labels Mar 30, 2023
@xnyo xnyo self-assigned this Mar 30, 2023
@xnyo xnyo changed the title Tracing: Support multiple Otel propagators Tracing: Support multiple OTel propagators Mar 30, 2023
@xnyo xnyo marked this pull request as ready for review April 4, 2023 12:46
@xnyo xnyo requested a review from a team as a code owner April 4, 2023 12:46
@xnyo xnyo requested review from wbrowne and andresmgot and removed request for a team April 4, 2023 12:46
@xnyo xnyo mentioned this pull request Apr 4, 2023
Merged
3 tasks
marefr
marefr approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor question

internal/tracerprovider/tracerprovider.go Show resolved Hide resolved
@xnyo xnyo merged commit 41c6544 into main Apr 4, 2023
@xnyo xnyo deleted the giuseppe/tracing-multiple-propagators branch April 4, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marefr marefr marefr approved these changes

@wbrowne wbrowne Awaiting requested review from wbrowne wbrowne is a code owner automatically assigned from grafana/plugins-platform-backend

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/plugins-platform-backend

Assignees

@xnyo xnyo

Labels
enhancement New feature or request go Pull requests that update Go code
Projects
Plugins Platform
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracing: Support multiple OTEL propagators
2 participants
@xnyo @marefr