Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependencies #672

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Bump dependencies #672

merged 3 commits into from
Apr 28, 2023

Conversation

xnyo
Copy link
Member

@xnyo xnyo commented Apr 27, 2023 •
edited

What this PR does / why we need it:

Bumps dependencies to their latest version:

  • github.com/hashicorp/go-plugin v1.4.3 -> v1.4.9
  • github.com/hashicorp/go-hclog v1.2.0 -> 1.5.0
  • google.golang.org/protobuf v1.28.1 -> v1.30.0
  • google.golang.org/grpc already on latest (v1.54.0)

Matches versions with grafana/grafana#67373

I have done the following tests:

  • new sdk dependencies with new grafana dependencies
  • new sdk dependencies with old grafana dependencies (main, 9.5, 9.4, 8.5, 8.0)
  • old sdk dependencies with new grafana dependencies

Making sure that:

  • Backend plugins start and function correctly
  • Nothing weird is being logged to Grafana's stdout

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@xnyo xnyo added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Apr 27, 2023
@xnyo xnyo self-assigned this Apr 27, 2023
@xnyo xnyo mentioned this pull request Apr 28, 2023
Merged
8 tasks
@xnyo xnyo marked this pull request as ready for review April 28, 2023 08:40
@xnyo xnyo requested a review from a team as a code owner April 28, 2023 08:40
wbrowne
wbrowne approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for taking this on ❤️

marefr
marefr approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great

@xnyo xnyo merged commit 7ae1975 into main Apr 28, 2023
@xnyo xnyo deleted the giuseppe/bump-plugins-dependencies branch April 28, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbrowne wbrowne wbrowne approved these changes

@marefr marefr marefr approved these changes

@andresmgot andresmgot andresmgot approved these changes

Assignees

@xnyo xnyo

Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
Plugins Platform
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xnyo @wbrowne @marefr @andresmgot