Makes sure go build manifest file is generated with POSIX separators #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
academo
requested review from
wbrowne and
andresmgot
and removed request for
a team
xnyo
approved these changes
May 16, 2023
yes you are correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It makes sure the generated go manifest file outputs POSIX paths in all systems.
With the previous version, manifests generated in windows machines would use back slashes instead of forward slashes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I tested this change using a windows 11 virtual machine with the latest go 1.20.x. It looks like pathfile.ToSlash behaves different based on the OS. In linux doesn't convert backslashes to forward-slashes.