return response with message when err occurs with a response #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottlepp
requested review from
wbrowne,
andresmgot and
yesoreyeram
and removed request for
a team
scottlepp
changed the title
|
Apparently some security concerns in Grafana cloud. https://raintank-corp.slack.com/archives/C01C4K8DETW/p1686165540640439 Though we still need a way to provide immediate feedback to the user so they know what they did wrong in the settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When an error is returned we only receive a generic message "Plugin health check failed"
This change returns a response with the message and displays it on the health check page.
Which issue(s) this PR fixes:
https://github.com/grafana/support-escalations/issues/6150