Add method Fingerprint to data.Labels #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri-tceretian
requested review from
marefr and
andresmgot
and removed request for
a team
|
|
This comment was marked as outdated.
This comment was marked as outdated.
yuri-tceretian
force-pushed
the
yuri-tceretian/labels-hash
branch
from
f827995
to
88e65aa
Compare
andresmgot
reviewed
Jul 6, 2023
There was a problem hiding this comment.
Thanks @yuri-tceretian, I have some questions, apart from that adding the rest of the @grafana/plugins-platform-backend as reviewer in case they have more feedback.
| @@ -80,6 +81,33 @@ func (l Labels) String() string { | |||
| return sb.String() | |||
| } | |||
|
|
|||
| type Fingerprint uint64 | |||
There was a problem hiding this comment.
Few reasons:
- standard type is too general and may be confusing to read in the code when passed around in user code.
- simpler to track where the type\value originated.
- add the possibility to extend the type with methods. For example, Stringer interface.
- improves maintainability. If we decide to switch from uint64 to byte array or string, less code will need to be rewritten.
There was a problem hiding this comment.
Also, I added String() to represent the hash as a sequence of hex numbers
xnyo
approved these changes
Jul 7, 2023
kylebrandt
approved these changes
Jul 7, 2023
|
Thanks, everyone for the review!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the method Fingerprint to labels that calculates 64-bit FNV-1 hash of the labels.
Which issue(s) this PR fixes:
Related to grafana/grafana#70998
Special notes for your reviewer: