-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump OpenTelemetry dependencies and its direct and indirect dependencies #719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving a note here that this should be manually tested before merged (due to the changes in grpc
and protobuf
dependencies). Will get to this ASAP
@@ -20,10 +20,10 @@ require ( | |||
github.com/olekukonko/tablewriter v0.0.5 | |||
github.com/prometheus/client_golang v1.14.0 | |||
github.com/prometheus/common v0.42.0 | |||
github.com/stretchr/testify v1.8.2 | |||
github.com/stretchr/testify v1.8.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only packages under the go.opentelemetry.io
namespace were manually upgraded by me, the others are all modified by go get -u
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested GRPC/Protobuf changes and they seem good!
LGTM! Thank you, and sorry for the delay 😅
This PR supersedes #696, #694, #693.
In
clickhouse-datasource
, we to started see pipeline failures because Dependabot is trying to roll back theclickhouse driver
to2.3.0
. After some assistance from a GitHub dev (thank you!), we found thatgo get
was resolving dependencies incorrectly. Runninggo get github.com/ClickHouse/clickhouse-go/v2
, thengo get github.com/grafana/grafana-plugin-sdk-go
, thengo mod tidy
, produced the following output:When
grafana-plugin-sdk-go
is resolved by the package manager, that downgradesclickhouse-go
tov2.3.0
as that's the latest version that it can reconcile the version ofotel/trace
depended on by bothclickhouse-go
andgrafana-plugin-sdk-go
.This PR bumps all the OpenTelemetry packages all at once with the
-u
flag so that interlinking dependencies betweenopentelemetry-go
andopentelemetry-go-contrib
and it's dependencies are resolved. After a release, this should fix the issue we are experiencing.