Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supported multiple result sets in *sql.Rows result from db.QueryContext #735

Merged
merged 4 commits into from
Sep 20, 2023
Merged

supported multiple result sets in *sql.Rows result from db.QueryContext #735

merged 4 commits into from
Sep 20, 2023

Conversation

asmyasnikov
Copy link
Contributor

What this PR does / why we need it:
Since go1.8 *sql.Rows supports multiple result sets. But grafana-plugin-sdk-go doesn't take this into.
This PR improved grafana-plugin-sdk-go for supporting multiple result sets in db.QueryContext result

Which issue(s) this PR fixes:
Some databases (like YDB) have stream protocol inside. Because designed for large data sets. This fact determines stream API for getting result from server. Multiple result sets is normal for iterate between result batches

Fixes #

Special notes for your reviewer:

@asmyasnikov asmyasnikov requested a review from a team as a code owner September 13, 2023 17:20
@CLAassistant
Copy link

CLAassistant commented Sep 13, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Raubzeug
Copy link

Hi! Could you please provide with further steps to merge this PR and deploy a new version? YDB team is waiting for this improvement to fix a bug in our Grafana plugin.
Thanks in advance!

@scottlepp scottlepp merged commit 6485d5a into grafana:main Sep 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants