Contextual tracer from multi-tenancy #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xnyo
changed the title
xnyo
requested review from
wbrowne,
andresmgot and
oshirohugo
and removed request for
a team
xnyo
commented
Oct 17, 2023
| ) | ||
|
|
||
| const ( | ||
| attributeNameTenantID = "tenant_id" |
There was a problem hiding this comment.
@wbrowne any opionins on the name? The runner currently uses stackID in its own spans:
However OTEL suggests using snake_case:
https://opentelemetry.io/docs/specs/otel/common/attribute-naming/
There was a problem hiding this comment.
Yeah fair 👍 We can update that in the runner side, and maybe keep stackID/stackId for the logs
This was referenced Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
tenant_idspan attribute to all spans created by the default tracer.Which issue(s) this PR fixes:
Fixes to #724
Special notes for your reviewer: