Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magefile: Allow to specify a folder holding the plugin.json #778

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

andresmgot
Copy link
Contributor

What this PR does / why we need it:

The other two directories (pkg and dist) are already configurable but not one including the plugin.json (src). I need this in order to be able to use the BuildAll target in Grafana.

Which issue(s) this PR fixes:

Related to #74004

Special notes for your reviewer:

@andresmgot andresmgot requested a review from a team as a code owner October 18, 2023 14:14
@andresmgot andresmgot requested review from wbrowne, oshirohugo and xnyo and removed request for a team October 18, 2023 14:14
Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@andresmgot andresmgot merged commit 88c9fc2 into main Oct 19, 2023
2 checks passed
@andresmgot andresmgot deleted the buildSrcDir branch October 19, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants