Mark all pub types #[non_exhaustive] #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More fields could be added to Grafana at any time, and we'd need to release a new minor version without these structs/enums being marked #[non_exhaustive]. This does unfortunately make the API a bit less convenient to use unless we provide 'with_x' methods all over the place, which we could always do later.
sd2k
force-pushed
the
non-exhaustive-pub-types
branch
from
0b4bc49
to
040409d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fields or variants could be added to Grafana at any time, and we'd
need to release a new minor version without these structs/enums
being marked
#[non_exhaustive]. This does unfortunately make theAPI a bit less convenient to use unless we provide
with_xmethodsall over the place, which we could always do later.
This follows on from #34 but applies to the
datamodule instead of thebackendone.