Bump prost to 0.11.0 and tonic to 0.8 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sd2k
force-pushed
the
bump-prost-0.11-tonic-0.8
branch
3 times, most recently
from
d18b923
to
06fa222
Compare
This was referenced Aug 9, 2022
|
Marking as draft until hyperium/tonic#1065 is merged and released, and I can remove the patches. |
sd2k
force-pushed
the
bump-prost-0.11-tonic-0.8
branch
from
e397002
to
bd70dc5
Compare
This also removes the build dependencies on prost-build and tonic-build because of the new requirement for `protoc` to be installed. Instead, the generated code is committed as part of this PR, with instructions on how to regenerate it in Cargo.toml. The build script is still present but disabled using `build = false` in Cargo.toml. This should speed up build times and reduces our dependencies, which is great!
sd2k
force-pushed
the
bump-prost-0.11-tonic-0.8
branch
from
bd70dc5
to
88ad9f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the build dependencies on prost-build and tonic-build
because of the new requirement for
protocto be installed. Instead,the generated code is committed as part of this PR, with instructions on
how to regenerate it in Cargo.toml. The build script is still present
but disabled using
build = falsein Cargo.toml.This should speed up build times and reduces our dependencies, which is
great!