Allow custom types for JSON/secure JSON data of plugins #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sd2k
force-pushed
the
strongly-typed-json-data
branch
3 times, most recently
from
0b08020
to
ad1dac4
Compare
sd2k
changed the title
sd2k
force-pushed
the
strongly-typed-json-data
branch
2 times, most recently
from
8dff6d8
to
af5b2d1
Compare
sd2k
force-pushed
the
strongly-typed-json-data
branch
2 times, most recently
from
07250f8
to
0c2ea22
Compare
This commit allows plugins to specify the concrete type of the JSON/secure JSON data decoded into the `PluginContext.instance_settings` field on incoming requests. They do so by implementing a new `GrafanaPlugin` trait (which all plugins must now do); this is made easier by using an identically named derive macro and specifying the custom types as attributes.
It turns out this can be optional if the request targets a datasource but not a datasource instance.
This no longer works because the trait requires `GrafanaPlugin` as a supertrait of the implementing type, unfortunately.
We should never return a tonic error, just convert any errors into a string representation.
sd2k
force-pushed
the
strongly-typed-json-data
branch
from
a912022
to
cd4cb83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows plugins to specify the concrete type of the
JSON/secure JSON data decoded into the
PluginContext.instance_settingsfield on incoming requests. They do so by implementing a new
GrafanaPlugintrait (which all plugins must now do); this is madeeasier by using an identically named derive macro and specifying the
custom types as attributes.