Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite global aliasing with boolean switch #301

Merged

Conversation

dgarcia-collegeboard
Copy link
Contributor

This enhancment makes global aliasing truly global. Composite names now also receive global aliasing if global aliasing is toggled to true in composites dropdown.

Changes:

  • Add boolean switch to enable / disable composite global aliasing
  • Apply global aliasing to composite display name if boolean switch is enabled (defaulted to false, so that current panels are unaffected by this enhancement, but can enable it if desired)
  • Adjust ApplyComposites method to require new arguments to support this feature
  • Adjust tests so they are passing

I have not had the ability to create new tests to ensure future reliability of this feature. This is one thing I could use some help on, if possible, since I am not great at creating react-style tests.

Please let me know if further adjustments are required. Thanks!

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2023

CLA assistant check
All committers have signed the CLA.

@dgarcia-collegeboard
Copy link
Contributor Author

@briangann tagging for visibility

@briangann
Copy link
Collaborator

sorry for the delay, will review this shortly! looks like a great addition

@briangann briangann added no stalebot This issue will be ignored by stalebot enhancement New feature or request labels Sep 12, 2023
@briangann briangann self-assigned this Sep 12, 2023
@briangann briangann self-requested a review September 12, 2023 03:59
Copy link
Collaborator

@briangann briangann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice feature addition!

@briangann briangann merged commit 9ab843a into grafana:main Sep 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no stalebot This issue will be ignored by stalebot
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants