change query signature #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergquist
reviewed
Apr 30, 2020
| @@ -33,10 +33,7 @@ func (td *SampleDatasource) QueryData(ctx context.Context, req *backend.QueryDat | |||
|
|
|||
| // loop over queries and execute them individually. | |||
| for _, q := range req.Queries { | |||
| res, err := td.query(ctx, q) | |||
| if err != nil { | |||
There was a problem hiding this comment.
I wanted to show that you can err in different ways. But that might not be suitable for tutorials/boilerplate.
There was a problem hiding this comment.
Understood, could move it into QueryData as per initial comment on PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think returning an error from query is a good pattern (although, one might return an error from functions within it, and then assign to response.Error).
Could restore comment about what happens when returning an error to the handle in calling function. Don't care about the named return if you don't want to use it here, but I think cleaner when there is no initialization to do and a single return param.