Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backend datasource patterns: #25

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Update backend datasource patterns: #25

merged 1 commit into from
Jun 28, 2021

Conversation

MasslessParticle
Copy link
Contributor

@MasslessParticle MasslessParticle commented Jun 14, 2021

The enterprise plugins team have some new plugin patterns that we'd like to encourage by adding them to the default project:

  • Move plugin business logic to 'plugin' package to encourage cleaner testing
    and separation from main.
  • Add some sample tests
  • bump the SDK

@MasslessParticle MasslessParticle marked this pull request as draft June 14, 2021 21:58
@MasslessParticle MasslessParticle marked this pull request as ready for review June 14, 2021 22:07
@MasslessParticle MasslessParticle requested review from FZambia and bergquist and removed request for FZambia June 14, 2021 22:07
@bergquist bergquist requested review from wbrowne and removed request for bergquist June 28, 2021 07:27
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Move plugin business logic to 'plugin' package to encourage cleaner testing
  and separation from main.
- Add a sample test
- bump the SDK
@wbrowne wbrowne merged commit b4c14a4 into main Jun 28, 2021
@wbrowne wbrowne deleted the pattern-updates branch June 28, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants