-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: upgrades rxjs resolution to 7.3.0 #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @hugohaggmark ! 👏
@jackw seems like the build step |
Not sure why this is stuck, might be because we stopped using the GitHub actions from https://github.com/grafana/plugin-workflows. I'm going ahead and merging this anyway because the Drone build is green. |
@hugohaggmark - Can all the existing plugins use this resolution? will that cause any conflicting issues when using older versions of grafana with latest rxjs resolution? Some plugin depends on |
I think that is another issue that needs to be addressed in the future. I think right now we always target the latest version of Grafana. Please correct me if I'm wrong @jackw @mckn |
That is correct but we are planning on improving the toolkit in |
FYI. All the Grafana enterprise plugins are using |
Opened this PR because of this comment.