Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: upgrades rxjs resolution to 7.3.0 #30

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Chore: upgrades rxjs resolution to 7.3.0 #30

merged 2 commits into from
Aug 20, 2021

Conversation

hugohaggmark
Copy link
Contributor

@hugohaggmark hugohaggmark commented Aug 17, 2021

Opened this PR because of this comment.

@hugohaggmark hugohaggmark added the dependencies Pull requests that update a dependency file label Aug 17, 2021
Copy link
Contributor

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @hugohaggmark ! 👏

@hugohaggmark
Copy link
Contributor Author

@jackw seems like the build step plugin_workflow is stuck?

@hugohaggmark
Copy link
Contributor Author

Not sure why this is stuck, might be because we stopped using the GitHub actions from https://github.com/grafana/plugin-workflows. I'm going ahead and merging this anyway because the Drone build is green.

@hugohaggmark hugohaggmark merged commit c40d172 into main Aug 20, 2021
@hugohaggmark hugohaggmark deleted the hugoh/rxjs7 branch August 20, 2021 07:46
@yesoreyeram
Copy link

@hugohaggmark - Can all the existing plugins use this resolution? will that cause any conflicting issues when using older versions of grafana with latest rxjs resolution? Some plugin depends on @grafana/{ui/data/runtime/toolkit} packages with version 7.x

@hugohaggmark
Copy link
Contributor Author

@hugohaggmark - Can all the existing plugins use this resolution? will that cause any conflicting issues when using older versions of grafana with latest rxjs resolution? Some plugin depends on @grafana/{ui/data/runtime/toolkit} packages with version 7.x

I think that is another issue that needs to be addressed in the future. I think right now we always target the latest version of Grafana. Please correct me if I'm wrong @jackw @mckn

@mckn
Copy link

mckn commented Aug 24, 2021

@hugohaggmark - Can all the existing plugins use this resolution? will that cause any conflicting issues when using older versions of grafana with latest rxjs resolution? Some plugin depends on @grafana/{ui/data/runtime/toolkit} packages with version 7.x

I think that is another issue that needs to be addressed in the future. I think right now we always target the latest version of Grafana. Please correct me if I'm wrong @jackw @mckn

That is correct but we are planning on improving the toolkit in v8.3 to make it use template depending on its current version. It will resolve issues like this.

@yesoreyeram
Copy link

FYI. All the Grafana enterprise plugins are using @grafana/{ui/data/runtime/toolkit}:7.5.0 and performing rxjs resolution to 6.6.3. They will stick with it atleast until next few months. Wondering what impact they will have when customer uses latest grafana having this PR. Are they backward compatible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants