Add tsconfig line for DataSourceVariableSupport #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going through old prs and I don't really remember why I made this so just going to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons that are still a bit mysterious to me, when working on Template Variables for a new plugin we tried to reuse the QueryEditor for query template variables with DataSourceVariableSupport and we hit the following error:
TypeError: class constructors must be invoked with 'new'This error seems to go away when we add this line to our tsconfig. 🤷♀️ What's particularly confusing to me is that I didn't see any tsconfig errors in yarn watch or yarn build. Maybe someone better with typescript/es6 can better explain what's going on here, but I think we should probably add this to our template.