Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: add deprecation notice #37

Merged
merged 1 commit into from
Oct 19, 2022
Merged

README: add deprecation notice #37

merged 1 commit into from
Oct 19, 2022

Conversation

leventebalogh
Copy link
Contributor

@leventebalogh leventebalogh commented Mar 4, 2022 •
edited

What changed?

Added a deprecation notice to the README and linked the new grafana/grafana-plugin-examples repo as the place to go to.

Check out the updated README

Preview:
Screenshot 2022-03-04 at 10 31 36

@leventebalogh leventebalogh requested a review from jackw March 4, 2022 09:33
@leventebalogh leventebalogh self-assigned this Mar 4, 2022
jackw
jackw approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

IMHO I think we should probably hold off merging this until we have the plugin-examples scaffolded plugins in a consistent state.

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@tolzhabayev
Copy link
Collaborator

@leventebalogh @jackw I think the state is consistent enough to pull the trigger, or wdyt?

@leventebalogh
Copy link
Contributor Author

I think so, too, let me merge it. 👍

@leventebalogh leventebalogh merged commit 07cd551 into main Oct 19, 2022
@leventebalogh leventebalogh deleted the leventebalogh/add-deprecation-notice branch October 19, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

Assignees

@leventebalogh leventebalogh

Labels
None yet
Projects
Plugins Platform
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leventebalogh @CLAassistant @tolzhabayev @jackw