Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add react and react-dom to dependencies for 9.2.0 #40

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

jackw
Copy link
Contributor

@jackw jackw commented Oct 17, 2022

The grafana browser packages (data, runtime, ui) require react and react-dom as peer deps. This PR adds these react packages to the dependencies and moves the packages into the correct devDep and dep fields.

Copy link
Contributor

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jackw jackw merged commit 8d3a93b into main Oct 20, 2022
@jackw jackw deleted the jackw/add-react-peer-deps branch October 20, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants