Support for secure socks proxy #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesoreyeram
approved these changes
Jul 6, 2023
|
LGTM. 🔥 Can you bump the version and update the CHANGELOG please? |
alexanderzobnin
approved these changes
Jul 25, 2023
alexanderzobnin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR enables support for the secure socks proxy, which is a new feature in Grafana 10. The feature allows datasource connections to be proxied through a socks5 proxy with TLS. This enables Grafana users to connect to datasources that live in different networks than where Grafana is running when they cannot open up ports to the public internet.
Implementation notes
github.com/grafana/grafana-plugin-sdk-go v0.163.0and underlying dependencies.github.com/grafana/grafana-plugin-sdk-go/backend/httpclient, there are no more changes needed in the backend, the config is read and loaded in that library.Fixes #1653
Screenshot: