-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Dependency clean up #1692
Conversation
jest.mock('grafana/app/core/core', () => ({ | ||
contextSrv: {}, | ||
}), {virtual: true}); | ||
jest.mock( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is changed because of prettier format
"minimatch": "^3.0.2", | ||
"fstream": "^1.0.12" | ||
} | ||
"jackspeak": "2.1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to pin this dependency because of an issue in yarn 1. See storybookjs/storybook#22431 (comment) for more info.
@@ -48,7 +48,7 @@ services: | |||
POSTGRES_DB: zabbix | |||
|
|||
database: | |||
image: postgres | |||
image: postgres:15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are multiple devenv-docker-compose files with this postgres-entry.. do we want to fix all of them in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think that makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I had to bump this because postgres translates to the latest which is 16 and zabbix server shuts down with an error:
Unable to start Zabbix server due to unsupported PostgreSQL database version (16.0). Must not be higher than (15.x)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice work. LGTM 👍
I wonder if @alexanderzobnin is ok with these changes? |
In this PR: