Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add elasticsearch alerting #11368

Closed
8 of 13 tasks
wph95 opened this issue Mar 23, 2018 · 3 comments
Closed
8 of 13 tasks

add elasticsearch alerting #11368

wph95 opened this issue Mar 23, 2018 · 3 comments

Comments

@wph95
Copy link
Contributor

wph95 commented Mar 23, 2018

feature

  • base on 5.0.1
  • No Third-party elasticsearch Golang SDK used
  • Strictly follow the implementation of other datasouce code [mostly influxdb datasource]
  • Control line of source code is around 1000 lines [no including test]
  • Code logic strictly follow the implementation of public/app/plugin/app/elasticsearch, e.g.
    • query.go -> query_builder.ts
    • response_parser.go -> elastic_response.ts

CODING PHASE 1 [Finished]

  • parser Grafana internal elasticsearch query model -> model_parser.go
  • convert query model to elasticsearch search body -> query_builder.go
  • ElasticsearchExecutor -> elasticsarch.go
  • parser elasticsarch response -> response_parser.go [in process]

in this phase, I plan to unsupported

  • pipeline aggs [I haven't fully understood this part. =.=]

CODING PHASE 2 [Finished]

  • get Series Name support
  • index list support interval (maybe import third part golang moment lib)
  • pipeline aggs support
  • some necessary tests

CODING PHASE 3

  • A full covering test suite exists.
    • test pipeline aggs response
  • trim Datapoints support
  • processAggregationDocs
  • more clearly golang es model -> models.go
@bergquist
Copy link
Contributor

How does this compare to #8934 ?

@wph95
Copy link
Contributor Author

wph95 commented Mar 23, 2018

hi @bergquist , i see roadmap delayed elasticsearch alerting, and #8943 look like hard to merge and no one to maintain, so I want to contribute to the community. and write a simple, clea, small pr :)

Although #8934 has been running steadily for a year in the production environment, but is difficult to merge into Master for some reason #8934 (comment)

this pr solved most problems

i will finished CODING PHASE 1 in today [GMT+8] wph95#2
and plan to finished CODING PHASE 2 in this weekend

Finally, please forgive my English writing ability is not good

@wph95 wph95 changed the title [wip] add elasticsearch alerting add elasticsearch alerting Mar 24, 2018
@bergquist bergquist added this to the 5.2 milestone Apr 10, 2018
@marefr
Copy link
Member

marefr commented May 24, 2018

I'm closing this since we already have an open feature request issue for elasticsearch alerting. Further discussions around PR will be discussed in PR.

@marefr marefr closed this as completed May 24, 2018
@marefr marefr removed this from the 5.2 milestone May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants