Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Find dashboards in folders you do not have access to #12948

Closed
volter opened this issue Aug 16, 2018 · 13 comments
Closed

Dashboard: Find dashboards in folders you do not have access to #12948

volter opened this issue Aug 16, 2018 · 13 comments
Labels
area/dashboard/folders area/permissions stale Issue with no recent activity type/feature-request version/5 for issues related to version 5

Comments

@volter
Copy link
Contributor

volter commented Aug 16, 2018

What Grafana version are you using?

5.2.2

What did you do?

I'm trying to grant privileges of a single dashboard inside a folder that also contains other dashboards, without grants.

What was the expected result?

I expected to see that folder on the menu and I expected only that one dashboard to be visible.

What happened instead?

If I'm not granting anything to the folder, the folder won't show. However, the dashboard is available when sharing the URL. If instead I am granting permissions for the folder, all of the dashboards it contains are visible. That makes sense as more generic rules win, like the documentation says. However, granting access for a single dashboard doesn't make much sense if you can not navigate there.

@marefr
Copy link
Member

marefr commented Aug 16, 2018

What menu? Could you please include some screenshots which describes your problem and how you've configured your permissions and for what user/team?

@marefr marefr added the needs more info Issue needs more information, like query results, dashboard or panel json, grafana version etc label Aug 16, 2018
@volter
Copy link
Contributor Author

volter commented Aug 17, 2018

I created a user who's role is set to "Viewer". I created a team ("interested team") and added this user to it.

A folder called "Folder with secret and not quite as secret dashboards" contains certain "not quite as secret" dashboards I want members of the "interested team" to see.

Neither the team nor the user were granted permissions on the folder, as this would gain them access to all of the dashboards. I therefore only granted permissions on the dashboard to the team.

By "menu" I meant the dashboard search (http://docs.grafana.org/reference/search/). It just won't show the folder, although the team has access to a dashboard inside of it.

screenshot_20180817_105026
screenshot_20180817_105516
screenshot_20180817_105736

@marefr
Copy link
Member

marefr commented Aug 17, 2018

Thanks @volter

The first screenshot on top is that when logged in as this new user which is a member of the interested team?

@volter
Copy link
Contributor Author

volter commented Aug 17, 2018

No, that's just to illustrate what the Administrator can see. The folder is not visible for the team member at all.

@volter
Copy link
Contributor Author

volter commented Sep 7, 2018

Are you still missing information here?

@marefr marefr added type/bug area/dashboard/folders area/permissions and removed needs more info Issue needs more information, like query results, dashboard or panel json, grafana version etc labels Sep 8, 2018
@marefr marefr added this to the 5.4 milestone Sep 8, 2018
@marefr
Copy link
Member

marefr commented Sep 8, 2018

Thanks @volter

@bergquist bergquist modified the milestones: 5.4-beta1, 5.5 Nov 12, 2018
@bergquist bergquist removed this from the 5.5 milestone Jan 11, 2019
@norbertwnuk
Copy link

norbertwnuk commented Mar 25, 2019

The issue is still there in Grafana 6.0.2, Dashboard level permissions do not override Folder level configuration. Cannot effectively make single dashboard public (e.g. Everyone with Viewer role) in private Folder. That contradicts documentation where permission propagation is described, it was (somehow) working for us in Grafana 5.3.x - it might indicating regression introduced by some bug-fix / back-porting.
The workaround would be to add View access for Everyone with Viewer role on Folder level, since it does not propagate to dashboard level still can mark dashboards selectively plus have Folder visible for all.

@norbertwnuk
Copy link

The tweak is already prepared based on the work in: #10339 (#10339 (comment))

@konradgaluszka
Copy link

Update. PR solving this is in #16741.

@konradgaluszka
Copy link

konradgaluszka commented May 19, 2019

@torkelo Can this be merged?
The code doesn't change permissions model much, just lets the folders that contain dashboards accessible to user to be returned in query. Also hides edit 'cog' icon for such folders because it does not make sense to see what is inside.
thanks

Edit:
@marefr can you also look? PR solving this is in #16741. I'm not sure what are the chances of having this merged.
Thanks

@jmurraywv
Copy link

Has this been resolved?

@torkelo torkelo changed the title Show folder in menu when permissions are granted on a dashboard it contains Dashboard: Find dashboards in folders you do not have access to Nov 2, 2020
@ivanahuckova ivanahuckova added the version/5 for issues related to version 5 label Nov 11, 2020
Copy link
Contributor

This issue has been automatically marked as stale because it has not had activity in the last year. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

@github-actions github-actions bot added the stale Issue with no recent activity label Jan 19, 2024
Copy link
Contributor

This issue has been automatically closed because it has not had any further activity in the last 30 days. Thank you for your contributions!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard/folders area/permissions stale Issue with no recent activity type/feature-request version/5 for issues related to version 5
Projects
None yet
8 participants