Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent build packages due to the use of ubuntu:latest base image #18046

Closed
hassanfarid opened this issue Jul 10, 2019 · 5 comments · Fixed by #18224
Closed

Inconsistent build packages due to the use of ubuntu:latest base image #18046

hassanfarid opened this issue Jul 10, 2019 · 5 comments · Fixed by #18224

Comments

@hassanfarid
Copy link
Contributor

What happened:
In the latest beta release, we have made changes to docker image files to take ubuntu:latest ad base image.
This was initiated from #14182 and changes are merged using #17066 .

What will happen?

I think this can lead to inconsistent resultant image based on when grafana docker image is built. If in the future, ubuntu:latest moves to a newer version, this will change environment for builds.

What should happen?

It is general industry standard to use specific version label instead of label, so that the artifacts of build process are always predictable.

I suggest that we replace ubuntu:latest with ubuntu:18.04 at places that are effected by #17066 .

Environment:

  • Grafana version: v6.3.0-beta1 (2019-07-10)
@xlson
Copy link
Contributor

xlson commented Jul 11, 2019

Yes, I agree. We will make that change for the stable release.

@xlson xlson added this to the 6.3.0 milestone Jul 11, 2019
@hassanfarid
Copy link
Contributor Author

Can I pick this up?

@marefr
Copy link
Member

marefr commented Jul 11, 2019

@hassanfarid sure, that would be helpful.

@torkelo
Copy link
Member

torkelo commented Jul 22, 2019

I thought we had a PR that fixed this? But maybe confused it with another

@hassanfarid
Copy link
Contributor Author

@torkelo - here goes the PR : #18224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants