Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error when running plugin on unsupported version of Grafana #29660

Closed
marcusolsson opened this issue Dec 7, 2020 · 4 comments
Closed
Labels
area/plugins gh-discussions A label used for bulk-migration of FRs/ERs to discussions type/ux

Comments

@marcusolsson
Copy link
Contributor

What would you like to be added:

A user-friendly message telling the user that the plugin they're trying to use isn't supported for their Grafana version.

For example, if the user tries to run a panel plugin with grafanaDependency: ">=7.3.0" in the plugin.json on Grafana 7.2, they should receive an error along the lines of "This plugin requires a more recent version of Grafana".

Why is this needed:

If a plugin in the plugin directory depends on features that are only available in more recent versions of Grafana, it will throw cryptic errors/exceptions that can be hard to troubleshoot for most users.

@ryantxu
Copy link
Member

ryantxu commented Dec 10, 2020

Related issue -- the cli should check that it only installs valid versions and give warnings that a new version exists, but not supported.

The other thing to note is that the server in plugin.json is valid when the plugin is published -- we need something else to check the maximum version!

@marcusolsson
Copy link
Contributor Author

I believe the grafana-cli already checks whether the version is valid for the current Grafana version. Not everyone installs plugins via the CLI however, and it shouldn't be a big fix to check the semver of a plugin inside Grafana as well.

We validate every plugin that gets submitted to be published against the plugin.json JSON schema. JSON Schema doesn't have support for semver (we check against a regex right now), but we can add it to the plugin-validator as an extra check.

@ryantxu
Copy link
Member

ryantxu commented Dec 11, 2020

Excellent -- if the cli is doing that then we should update the server so it sends all versions, not just the ones that match -- we added that hack on the server side to avoid updating all the 7+ plugins on 6x grafana!

@wbrowne wbrowne moved this from Todo to Feature Requests in Plugins Platform (DEPRECATED) Jun 14, 2021
@pkolyvas pkolyvas added gh-discussions A label used for bulk-migration of FRs/ERs to discussions and removed type/feature-request labels Aug 20, 2021
@pkolyvas
Copy link
Contributor

We're in the process of moving Grafana feature requests to GitHub Discussions. This issue is being moved to Discussions or has been moved from our issues list, depending on where you're seeing this message.

We hope to use the discussion thread to continue building use cases, and additional evidence based on engagement/voting, in order to help us prioritize this feature request later on down the road.

As with all things Grafana, we value your input and participation in this project and appreciate your patience during this transitional period. Looking forward to the discussion!

@grafana grafana locked and limited conversation to collaborators Aug 20, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
area/plugins gh-discussions A label used for bulk-migration of FRs/ERs to discussions type/ux
Projects
None yet
Development

No branches or pull requests

4 participants