Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New server wide setting to disable saving new dashboards from the UI #32375

Open
holmesb opened this issue Mar 26, 2021 · 9 comments
Open

New server wide setting to disable saving new dashboards from the UI #32375

holmesb opened this issue Mar 26, 2021 · 9 comments
Labels
area/provisioning prio/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough interest in it. type/feature-request

Comments

@holmesb
Copy link

holmesb commented Mar 26, 2021

Hi,
It would be reasonable to expect allowUiUpdates: false to disallow UI updates to dashboards. Instead saving is allowed to dashboards that are created via the webui.

We have a gitops pipeline that manages dashboard changes declaratively. But there's nothing stopping users from creating new dashboards using the UI and pressing the Save button to save. We would prefer users to see the declarative save box:
image

which is what they correctly see when they try to save a declaratively provisioned dashboard. We have also tried setting editable: false. No difference. Likewise no dice if we change user rights from Editor to Viewer - they can't create new dashboards at all, and don't see the Save button in existing ones.

Please make allowUiUpdates: false disallow UI updates. Many thanks

@torkelo
Copy link
Member

torkelo commented Mar 27, 2021

allowUiUpdates only applies to a provisioned dashboard, it's not an option that prevents users from creating new ones

@torkelo torkelo closed this as completed Mar 27, 2021
@torkelo
Copy link
Member

torkelo commented Mar 27, 2021

But it sounds like you want a new server level setting do disallow new dashboards from being saved from the UI?

@holmesb
Copy link
Author

holmesb commented Mar 28, 2021

@torkelo - yes absolutely. Creating new dashboards should be possible, just saving them should be disallowed. Orgs like us who use helm, can manage dashboards declaratively, and would find this valuable. We'd like git to be the source of truth, which a new server level setting would facilitate. Should this issue be reopened, or should a new one be created?

@torkelo torkelo reopened this Mar 29, 2021
@torkelo torkelo changed the title "allowUiUpdates: false" fails least surprise New server wide setting to disable saving new dashboards from the UI Mar 29, 2021
@torkelo torkelo added type/feature-request prio/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough interest in it. area/provisioning labels Mar 29, 2021
@jakuboskera
Copy link

Some news regarding this feature?

We have exactly same problem. We would like to allow user to create a dashboard using grafana UI, but disable saving. With this approach user will have to export a JSON model of the dashboard a create CRD GrafanaDashboard in K8s. This will leads that all grafana instance can be declaratively described in git.

@tanandy
Copy link

tanandy commented Apr 8, 2022

We have the same issue, we would like to use only immutable dashboards and not beeing able to save it even for non provisioned

@holmesb
Copy link
Author

holmesb commented Apr 13, 2023

Be good to properly allow gitops workflows in Grafana @torkelo. Is this one on the roadmap? What "more-evidence" do you need?

@andyspiers
Copy link

This issue also affects us and several times now a developer (who was unaware that they must always check their dashboard JSON into our repo) has spent ages creating a dashboard and because they were just allowed to save it, did not realise that it was only persisted in the local container filesystem only to have it disappear whenever the Grafana pod is rescheduled.

@holmesb
Copy link
Author

holmesb commented Nov 18, 2023

Yes strange this gap hasn't yet been filled. Can implement the perfect gitops workflow, but users can subvert it by just creating a new dashboard and hitting save. If “allowUiUpdates: false” won't achieve, then a new setting is needed. How about “allowPersistNewDashboards: false”? Would default to “true”, so no breaking changes.

@mdvictor
Copy link
Contributor

@grafana/grafana-search-and-storage I'm not entirely sure this is dashboards. Could you also have a look over it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provisioning prio/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough interest in it. type/feature-request
Projects
Status: 🗂️ Needs Triage / Escalation
Development

No branches or pull requests

6 participants