Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus Query Editor: Obstructs keyboard navigation #35378

Open
tskarhed opened this issue Jun 8, 2021 · 1 comment
Open

Prometheus Query Editor: Obstructs keyboard navigation #35378

tskarhed opened this issue Jun 8, 2021 · 1 comment
Labels
area/frontend type/accessibility Accessibility problem / enhancement wcag/2.1.2 Keyboard focus can be moved away from a component if it can be received
Projects
Observability (deprecated, use Observ...
Milestone
8.2.0

Comments

@tskarhed
Copy link
Contributor

tskarhed commented Jun 8, 2021

Steps to reproduce:

  1. Go to Explore
  2. Choose a Prometheus datasource
  3. Navigate to the query field with tab

Actual Result:
A tab is put in the field

Expected Result
Some option to continue to navigate with tab. Discussions in Slack has come with a couple of suggestions, esc would exit edit mode. Toggling tab-trapper behaviour with a global Ctrl+M

Relevant WCAG Criteria: 2.1.2 WCAG Criterion
@tskarhed tskarhed added area/frontend type/accessibility Accessibility problem / enhancement labels Jun 8, 2021
@tskarhed tskarhed added this to the 8.1.0 milestone Jun 8, 2021
@tskarhed tskarhed self-assigned this Jun 8, 2021
@tskarhed tskarhed added this to In progress (max. internal 6) in Frontend Platform Backlog Jun 9, 2021
@tskarhed
Copy link
Contributor Author

tskarhed commented Jun 9, 2021

Modifying Slate's behaviour might be the solution here, which could also solve accessibility issues in other places.

@tskarhed tskarhed mentioned this issue Jun 10, 2021
Closed
@tskarhed tskarhed moved this from In progress (max. internal 6) to To do in Frontend Platform Backlog Jun 17, 2021
@wbrowne wbrowne modified the milestones: 8.1.0-beta1, 8.1.0 Jul 22, 2021
@idafurjes idafurjes modified the milestones: 8.1.0-beta3, 8.1.0 Jul 29, 2021
@wbrowne wbrowne modified the milestones: 8.1.0, 8.2.0 Aug 5, 2021
@andresmgot andresmgot modified the milestones: 8.2.0-beta1, 8.2.0 Sep 16, 2021
@ivanahuckova ivanahuckova modified the milestones: 8.2.0-beta2, 8.2.0 Sep 30, 2021
@mckn mckn removed this from Backlog in Frontend Platform Backlog Oct 4, 2021
@ckbedwell ckbedwell added the wcag/2.1.2 Keyboard focus can be moved away from a component if it can be received label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/frontend type/accessibility Accessibility problem / enhancement wcag/2.1.2 Keyboard focus can be moved away from a component if it can be received
Projects
Observability (deprecated, use Observ...
  
Awaiting triage
Milestone
8.2.0
Development

Successfully merging a pull request may close this issue.

QueryField: Make editor navigable with keyboard tskarhed/grafana
6 participants
@wbrowne @tskarhed @andresmgot @ckbedwell @ivanahuckova @idafurjes