Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Link: any following a data link cancels Kiosk mode #35691

Open
baur opened this issue Jun 15, 2021 · 4 comments
Open

Data Link: any following a data link cancels Kiosk mode #35691

baur opened this issue Jun 15, 2021 · 4 comments
Labels
area/dashboard/data-links help wanted prio/future Used by the dashboards squad to prioritise their backlog prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. team/grafana-dashboards Dashboards squad type/bug

Comments

@baur
Copy link

baur commented Jun 15, 2021

What happened:

Any data link cancels Kiosk mode,
Works if only add &kiosk to link, in previous version works wihtout &kiosk

What you expected to happen:

is this feature or bug?

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Grafana version: v8.0.2 (5c5d45e)
  • Data source type & version: MS SQL
  • OS Grafana is installed on: Windows 10
  • User OS & Browser: Chrome
  • Grafana plugins:
  • Others:
@baur baur changed the title Data Link: any link cancels Kiosk mode Data Link: any following a data link cancels Kiosk mode Jun 15, 2021
@marefr marefr added this to Needs triage in Platform Backlog via automation Jun 15, 2021
@marefr
Copy link
Member

marefr commented Jun 15, 2021

Confirmed bug locally using the gdev dashboard "Datalinks - variables" and clicking on data link lower right panel. Haven't compared with v7.x version though.

@dprokop dprokop removed this from Needs triage in Platform Backlog Jun 16, 2021
@dprokop dprokop added this to Bugs (max. 35) in Frontend Platform Backlog Jun 16, 2021
@dprokop dprokop moved this from Bugs (max. 35) to In progress (max. internal 6) in Frontend Platform Backlog Jun 16, 2021
@dprokop dprokop moved this from In progress (max. internal 6) to Bugs (max. 35) in Frontend Platform Backlog Jun 16, 2021
@jledun
Copy link

jledun commented Jun 16, 2021

I have the same problem when I'm using custom timeRange with I panel I've built. It's React panel running with grafana V8.0.2 on an Archlinux server and Google Chrome or Chromium as viewer.
I use onChangeTimeRange available in PanelProps object to update the displayed timeRange. The update delay is editable and can vary between 15 seconds to 5 minutes.

When I select kiosk mode with the help of the top right screen icon button then app appends "&kiosk" in the query string parameters and app goes into kiosk mode.
When the timeRange is updated, the query string parameters become "&kiosk=" without value => the app goes to normal mode, kiosk mode goes off.

If I set kiosk mode by adding by myself "&kiosk=1" to query string parameters then the bug disappears and the app stays in kiosk mode when the timeRange is updated.

I'm sorry for my language and I hope it helps...

@tskarhed tskarhed added the prio/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough interest in it. label Jun 23, 2021
@natellium natellium removed this from Bugs (max. 35) in Frontend Platform Backlog Jul 21, 2021
@axelavargas axelavargas added this to To be prioritised in User essentials squad (deprecated) Jul 22, 2021
@baur
Copy link
Author

baur commented Sep 29, 2021

any news?

@natellium natellium added help wanted and removed prio/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough interest in it. labels Apr 8, 2022
@joshhunt
Copy link
Contributor

Maybe related PR #43491

@natellium natellium added the prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jun 22, 2022
@natellium natellium added the team/grafana-dashboards Dashboards squad label Jun 23, 2023
@natellium natellium added the prio/future Used by the dashboards squad to prioritise their backlog label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard/data-links help wanted prio/future Used by the dashboards squad to prioritise their backlog prio/medium Important over the long term, but may not be staffed and/or may need multiple releases to complete. team/grafana-dashboards Dashboards squad type/bug
Projects
Status: 📝 Backlog
Development

No branches or pull requests

6 participants