Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting Graph (old) to Time series does not handle series overrides using regex #36085

Closed
Darth-Bobo opened this issue Jun 23, 2021 · 2 comments · Fixed by #36134
Closed
Assignees
Labels
area/panel/timeseries The main time series Graph panel type/bug

Comments

@Darth-Bobo
Copy link

What happened: Changing a graph of type "Graph (old)" to the new "Time series" converts a "series override" using a regex into a field "field with name" override instead of a "field with name matching regex" override.

What you expected to happen: The series override should convert to a field with name matching regex override where appropriate.

How to reproduce it (as minimally and precisely as possible):
Take any panel of type "Graph (old)", add a series override using a regex in the "Alias or regex" box.
Change the visualisation to "Time series". The override is converted to the wrong type with an error saying "(not found)".

Anything else we need to know?:

Environment:

  • Grafana version: 8.0.1
  • Data source type & version: AWS Timestream
  • OS Grafana is installed on: Amazon Linux 2
  • User OS & Browser: macOS Big Sur, Firefox 89.0.1
  • Grafana plugins:
  • Others:
@zuchka
Copy link
Contributor

zuchka commented Jun 23, 2021

Hi @Darth-Bobo,

Thanks for reporting this. I reproduced your error on our public sandbox. Let me know if I missed anything 👍

Confirming the "not found" text in the new override settings, inside the Time Series panel, as well:

CleanShot 2021-06-23 at 12 55 17@2x

@zuchka zuchka added area/panel/timeseries The main time series Graph panel type/bug labels Jun 23, 2021
@zuchka zuchka added this to Needs triage in Platform Backlog via automation Jun 23, 2021
@torkelo torkelo removed this from Needs triage in Platform Backlog Jun 24, 2021
@torkelo
Copy link
Member

torkelo commented Jun 24, 2021

We need to detect if alias here contains a regex and use a regex matcher instead: https://github.com/grafana/grafana/blob/main/public/app/plugins/panel/timeseries/migrations.ts#L115

@ashharrison90 ashharrison90 added this to Bugs (max. 35) in Frontend Platform Backlog Jun 24, 2021
@ashharrison90 ashharrison90 self-assigned this Jun 24, 2021
@ashharrison90 ashharrison90 moved this from Bugs (max. 35) to In Review (max. internal 8, external 3) in Frontend Platform Backlog Jun 24, 2021
Frontend Platform Backlog automation moved this from In Review (max. internal 8, external 3) to Done Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/panel/timeseries The main time series Graph panel type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants